> for the ui part - the color is not properly visible here (linux & qt plastic
style).
What do you mean with "not properly visible"? What color have you set and how
does it look?
> also from qt manuals it folows setStyleSheet is not supported under the
default
> MAC style.
What is a MAC style, and why is it default on Linux? Besides this, I implemented it the same way as
you set a color in the preferences of the Qt creator. Qt creator is available for all platforms, so
I suppose it works everywhere.
> the second button is unintuitive, at least tooltip should be added.
I'll add a tooltip. But why is it unintuitive? It is in my opinion self-explanatory - just press it
and you get its meaning. This button is btw. also taken from the Qt designer color handling.
> maybe we should use the color rectangle plues two buttons - similarly as we do
> in preferences of colors.
I don't like this way as one needs a list to draw in the color rectangle. We only have to set one
color here. I looked how other programs set colors and saw that every programs has its own way. The
way I implemented it is also used by the Qt programs, Mozilla programs (Firefox, Thunderbird), Adobe
programs (Photoshop, Illustrator), AutoCAD, Origin, ...
> maybe you could ask for review on list before commiting stuff like this ?
Its an easter egg ;-).
To be serious, I wrote an email about it and due to the commit you can test it. I assured not to
break anything but to find out how usable the implementation is, people need to play with it, use it
under different window styles, under different OSs, etc.. This way we can decide how to proceed with
the color handling. When only looking at the code, one misses the handling.
But OK, the next time I'll again post the code for review.
thanks and regards
Uwe
