On Thu, Jan 18, 2007 at 04:39:00PM +0100, Georg Baum wrote: > Enrico Forestieri wrote: > > > b) it doesn't hurt on cygwin as the functions dealing with conversions > > don't care about the encoding, > > Very good! You answered my question before I asked it ;-) > > > and c) this is the same on win32 with > > the exception of the already mentioned GetLongPathName case which could > > be replaced with GetLongPathNameW. > > > > If you don't care I would like to polish your commits in r16744:16745. > > I will do this later, as right now I don't have time. > > I think that is not needed anymore, since it looks like my patch goes > exactly into the direction you wanted. If you could test whether it does > what it is supposed to do that would be great.
Seems that we were reading each other mind: Your patch is more thorough than what I would have produced, but the overlaying parts would have been almost identical ;-) However, the patch seems incomplete to me as I don't see where from_filesystem8bit is defined. Anyway, I don't see how it could fail on both cygwin and win32. Please put it in and I'll test it later (and also accordingly update the patch attached to bug 3082). -- Enrico
