On Thu, Jan 18, 2007 at 02:15:23PM +0100, Abdelrazak Younes wrote: > Georg Baum wrote:
> > For now the std::string versions should be enough. > > > > I just see that you committed your patch, please revert it unless you have > > some convincing arguments why internal_path should be docstring and other > > file related functions not. > > OK, I will revert the os.h part. Thanks God! I had my heart in my mouth after seeing your first commit ;-) I think that eventually the filenames passed to the os_xxx.C functions should be in utf8 encoding because: a) they are mostly noops on *nix, b) it doesn't hurt on cygwin as the functions dealing with conversions don't care about the encoding, and c) this is the same on win32 with the exception of the already mentioned GetLongPathName case which could be replaced with GetLongPathNameW. If you don't care I would like to polish your commits in r16744:16745. I will do this later, as right now I don't have time. -- Enrico
