On Fri, Oct 06, 2006 at 01:55:31PM +0200, Jean-Marc Lasgouttes wrote: > >>>>> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: > > >> See above. Bo, you have your patch if you want to apply it to the > >> cygwin package. > > Georg> Under this circumstances I don't have anything against the > Georg> patch, but the people to ask are Lars for 1.5 and Jean-Marc for > Georg> 1.4 > > > I am a bit concerned about the amount of code this patch touches (were > all changes considered one-by-one?), but it clearly only impacts > cygwin. In this sense, it should be safe.
Yes, I thought very carefully that patch. In essence it allows using both windows and posix style paths on cygwin. As a side effect it allows using UNC paths. I was very careful to only allow either windows or posix style paths (i.e., not both at the same time) in os_cygwin.C, but if someone uses ERT or manually change the paths returned by the file dialog, either path styles could be fed up to boostfs. I also checked the patch against the test software provided by boost (e.g., simple_ls.cpp) and it works ok. When I build lyx on cygwin I also apply a patch introducing an environment variable (LYX_WINPATHS) which lets the user decide what path style is the default (windows or posix). This is very useful if you use native applications that do not understand posix paths, and it does not hurt the cygwin applications, as the vast majority of them has no problem with windows style paths. Of course, I am daily using the patch by months now and never had a problem with it (I have a mixed windows/cygwin environment). > I'd like to have more input from boost people, though. No need for this. I don't advocate the inclusion of the patch and I only mentioned it due to a problem rised on the cygwin mailing. -- Enrico
