>>>>> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:

>>  Simplified? The patch seems rather mechanical to me... What
>> changes do you have in mind?

Abdelrazak> I just mean that I simplified the interface of these
Abdelrazak> expand functions (no Buffer passing) that's all.

This is fine. Actually the remaining buffer passing points to a
strangeness in your new setting. Some functions like add() do not need
a buffer argument because theApp knows what the current buffer is.

However, some other functions need this buffer passing because theApp
won't tell what the current buffer is. Aren't we reintroducing the
dreaded current_view thingy?

Anyway, either there is a notion of current buffer(view), or we pass
buffer(view)s as parameters everywhere.

Abdelrazak> I am not sure I understand what you mean here. Do you want
Abdelrazak> a single function that does the check in any case? If yes,
Abdelrazak> I am OK with that too and I don't think that there will be
Abdelrazak> a noticeable performance penalty.

Yes, I'd prefer a single function that does the check in any case.

JMarc

Reply via email to