Jean-Marc Lasgouttes wrote:
"Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> What do you think of the attached. I even simplified some
Abdelrazak> expand functions...
Simplified? The patch seems rather mechanical to me... What changes do you
have in mind?
I just mean that I simplified the interface of these expand functions
(no Buffer passing) that's all.
I think I'd still prefer a single add that does the checks, since the
only reason for not passing view was lazyness on my part. Why do you
want to maintain this separation? I think this hardcoding based on
knowledge on the LFUN inner working is bad, unless we can _prove_ that
there is a speed advantage.
I am not sure I understand what you mean here. Do you want a single
function that does the check in any case?
If yes, I am OK with that too and I don't think that there will be a
noticeable performance penalty.
Abdel.
