>>>>> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:

Abdelrazak> Dear Jean-Marc, dear all, This change seems natural to me
Abdelrazak> as none of the LyXView features are used.

The expandFoo changes are correct, but I tend to think that the
following is not the best:
-       Menu & add(MenuItem const &, LyXView const * view = 0);
+       Menu & add(MenuItem const &, Buffer const * buf = 0);

What about removing the second parameter altogether? What are the
cases when add() can be called with view == 0?

I do not think the buffer parameter has any use here.

JMarc

Reply via email to