DavidSpickett marked an inline comment as done.
DavidSpickett added inline comments.
================
Comment at: lldb/include/lldb/Target/UnixSignals.h:127
+ struct SignalCode {
+ ConstString m_description;
+ SignalCodePrintOption m_print_option;
----------------
labath wrote:
> I think we should just make strings out of these, particularly since we now
> also have a map here. It's not like this is extremely performance-sensitive
> code.
Make strings in what way exactly. I used an enum just so it was harder to make
a typo and not realise.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146044/new/
https://reviews.llvm.org/D146044
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
