DavidSpickett marked 2 inline comments as done.
DavidSpickett added inline comments.
================
Comment at: lldb/source/Plugins/Process/Utility/FreeBSDSignals.cpp:14
FreeBSDSignals::FreeBSDSignals() : UnixSignals() { Reset(); }
void FreeBSDSignals::Reset() {
----------------
DavidSpickett wrote:
> arichardson wrote:
> > I wonder if it would make sense to do something like the following to
> > ensure we use the same numbers as defined in FreeBSD (compile-time checks
> > when building on a FreeBSD host). The it would be possible to use
> > `FREEBSD_ILL_ILLOPC` instead of `1 /*ILL_ILLOPC*/` below
> This is a cool idea, I'll give this a go (maybe as a follow up change).
https://reviews.llvm.org/D146222
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146044/new/
https://reviews.llvm.org/D146044
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
