emaste added inline comments.
================ Comment at: lldb/source/Plugins/Process/Utility/FreeBSDSignals.cpp:20 + // SIGILL + AddSignalCode(4, 1 /*ILL_ILLOPC*/, "illegal instruction"); + AddSignalCode(4, 2 /*ILL_ILLOPN*/, "illegal instruction operand"); ---------------- FreeBSD comment uses "illegal opcode" fwiw ================ Comment at: lldb/source/Plugins/Process/Utility/FreeBSDSignals.cpp:29 + + // SIGFPE + AddSignalCode(8, 1 /*FPE_INTDIV*/, "integer divide by zero"); ---------------- looks like the first two are swapped? ``` /* codes for SIGFPE */ #define FPE_INTOVF 1 /* Integer overflow. */ #define FPE_INTDIV 2 /* Integer divide by zero. */ ... ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146044/new/ https://reviews.llvm.org/D146044 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
