DavidSpickett added inline comments.
================ Comment at: lldb/include/lldb/Target/UnixSignals.h:127 + struct SignalCode { + ConstString m_description; + SignalCodePrintOption m_print_option; ---------------- DavidSpickett wrote: > labath wrote: > > I think we should just make strings out of these, particularly since we now > > also have a map here. It's not like this is extremely performance-sensitive > > code. > Make strings in what way exactly. I used an enum just so it was harder to > make a typo and not realise. @labath I'm going to start landing changes. If you still want this changed I'll do that in a later commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146044/new/ https://reviews.llvm.org/D146044 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits