jankratochvil added a comment.

The D91014 <https://reviews.llvm.org/D91014> patch has been found by a 
testsuite regression when running in DWZ mode. This patch has only the same 
pattern in the code and currently it is unclear whether this change is really 
reproducible or it is in fact just NFC.
OTOH I would find this change even as a code cleanup as (1) the code has less 
letters and (2) the previous code may work or not but the new code definitely 
should work.
I can check whether I can make a testcase for this patch as I agree new 
testcases are always good (but today it is 11pm here already).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96778/new/

https://reviews.llvm.org/D96778

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to