On May 6, 2009, at 5:01 PM, Wolfgang Denk wrote:
Dear Grant,
in message <fa686aa40905061333q29c263c8p24856c048e30f...@mail.gmail.com
> you wrote:
...
#ifdef CONFIG_FS_ENET_HAS_FEC
+#ifdef CONFIG_FS_ENET_MPC5121_FEC
+ {
+ .compatible = "fsl,mpc5121-fec",
+ .data = (void *)&fs_fec_ops,
+ },
+#else
{
.compatible = "fsl,pq1-fec-enet",
.data = (void *)&fs_fec_ops,
},
#endif
+#endif
Hmmm. A lot of these #ifdefs in here. Does this have a
multiplatform
impact? Not to mention the fact that it's just plain ugly. :-)
Agreed that it's ugly, but duplicatio9ng the code would have been even
worse. I don't think that it has multiplatform - at least not as long
as you don't ask for one image that runs on 83xx and on 512x.
We do ask for that. The fedora ppc6xx kernel should work on any 6xx/
7xx/7xxx based core chip. We should NOT be breaking such capability
in drivers.
- k
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
