Hi, Segher. Thanks > > + - compatible : set as "fsl,86xx-MSI" for 86xx cpu, > "fsl,85xx-MSI" > > for 85xx > > + cpu and "fsl,83xx-MSI" for 83xx cpu. > > Don't use "xx", use real device names instead. If for > example the oldest 86xx device that implements this is 8600, > and you write a tree for the 8699, you'd write compatible = > "fsl,8699-msi", "fsl,8600-msi"; and the driver will look for > "fsl,8600-msi" only usually, but it can take some special > actions for 8699 if it needs to. > > If these MSI devices work really identical for 83xx, 85xx, > 86xx, there is no need to distinguish between them for > probing either -- you want to use the same driver for all, anyway . The driver can work for 83xx, 85xx and 86xx, but the msiir offset is different for 83xx and 85xx/86xx cpu. I need this to get different msiir offset in the driver.
> Oh, and the norm is to write compatible values in lower case. Ok. > > + - msi-available-ranges: use <start count> style > section to define > > which > > + msi interrupt can be used in the 256 msi interrupts. > > Please make this property optional, default to "all available". > The value setting for this property is "all available", and this ranges maybe useful for some other MSI controller. Jason _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
