> -----Original Message----- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On > Behalf Of Grant Likely > Sent: Friday, May 09, 2008 9:25 PM > To: Jin Zhengxiong > Cc: [EMAIL PROTECTED]; linuxppc-dev@ozlabs.org > Subject: Re: [PATCH 1/4 V2] booting-without-of for Freescale MSI > > On Fri, May 9, 2008 at 3:03 AM, Jason Jin > <[EMAIL PROTECTED]> wrote: > > Binding document adding for Freescale MSI support. > > > > Signed-off-by: Jason Jin <[EMAIL PROTECTED]> > > --- > > Updated to V2 version per Segher's suggestion. > > > > Documentation/powerpc/booting-without-of.txt | 40 > +++++++++++++++++++++++++- > > 1 files changed, 39 insertions(+), 1 deletions(-) > > > > diff --git a/Documentation/powerpc/booting-without-of.txt > > b/Documentation/powerpc/booting-without-of.txt > > index 1d2a772..887783c 100644 > > --- a/Documentation/powerpc/booting-without-of.txt > > +++ b/Documentation/powerpc/booting-without-of.txt > > @@ -57,7 +57,10 @@ Table of Contents > > n) 4xx/Axon EMAC ethernet nodes > > o) Xilinx IP cores > > p) Freescale Synchronous Serial Interface > > - q) USB EHCI controllers > > + q) USB EHCI controllers > > + r) Freescale Display Interface Unit > > + s) Freescale on board FPGA > > + t) Freescael MSI interrupt controller > > > > VII - Marvell Discovery mv64[345]6x System Controller chips > > 1) The /system-controller node > > @@ -2870,6 +2873,41 @@ platforms are moved over to use the > flattened-device-tree model. > > reg = <0xe8000000 32>; > > }; > > > > + t) Freescale MSI interrupt controller > > + > > + Reguired properities: > > + - compatible : set as "fsl,86xx-MSI" for 86xx cpu, > "fsl,85xx-MSI" for 85xx > > + cpu and "fsl,83xx-MSI" for 83xx cpu. > > As Segher mentioned; don't use 'generic' compatible values. > Use names of *actual* devices and have newer parts claim > compatibility with older ones.
The *actual* devices that can use this MSI driver, is *all* the boards that use "86xx/85xx/83xx" cpu. This compatible note actually was used to distinguish different msiir offset for the boards use MPIC and IPIC. If "MPIC-MSI" or "85xx-MSI" is 'generic'. Do we need to describe it as "fsl,mpc8572ds-msi" and make all the boards who use MPIC compatible to "fsl,mpc8572ds-msi", Or each of the boards have their own compatible name and each time we add a board to support MSI, add an item to the of_device_id table? Please suggest, Thanks Jason _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
