Quoting Jonas Gorski (2019-04-08 03:20:34) > Add a generic flag to mark a clock as big endian register based, and add > accessors following these.
I like the idea of getting rid of clk_readl() and clk_writel(), but I'd rather see that this flag is per-basic clk type instead of global to all clks. Mostly because I don't see it as a clk property that's applicable in general. So we would either have a flag for dividers and gates that goes into the respective CLK_{GATE,DIVIDER}_* flag space, or some wrapper functions like: clk_gate_register_be() clk_divider_register_be() that passes this information through to the basic clk types somehow. Then if there's no other user left of clk_readl() and clk_writel() I'd just slam in a patch to all the files that use it to convert them to readl() and writel(). After that, it would be great to drop the io.h include from clk-provider.h and push that include out to any code that's relying on it implicitly.