On Nov 27, 2007, at 9:49 AM, Sergei Shtylyov wrote:
> Hello.
>
> Anton Vorontsov wrote:
>
>> This patch adds localbus and pata nodes to use CF IDE interface
>> on MPC8349E-mITX boards.
>
>> Patch also adds code to probe localbus.
>
>> Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
>> ---
>> arch/powerpc/boot/dts/mpc8349emitx.dts | 17 ++++++++++++++++-
>> arch/powerpc/platforms/83xx/mpc834x_itx.c | 17 +++++++++++++++++
>> 2 files changed, 33 insertions(+), 1 deletions(-)
>
>> diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts b/arch/powerpc/
>> boot/dts/mpc8349emitx.dts
>> index 5072f6d..7a97068 100644
>> --- a/arch/powerpc/boot/dts/mpc8349emitx.dts
>> +++ b/arch/powerpc/boot/dts/mpc8349emitx.dts
>> @@ -249,6 +249,21 @@
>> device_type = "pci";
>> };
>>
>> + [EMAIL PROTECTED] {
>> + #address-cells = <2>;
>> + #size-cells = <1>;
>> + compatible = "fsl,mpc8349emitx-localbus",
>
> Board compatible bus?
>
>> + "fsl,mpc8349e-localbus",
>> + "fsl,pq2pro-localbus";
>> + reg = <e0005000 d8>;
>> + ranges = <3 0 f0000000 210>;
>>
>> -
>> + [EMAIL PROTECTED],0 {
>> + compatible = "fsl,mpc8349emitx-pata", "pata-platform";
>> + reg = <3 0 10 3 20c 4>;
>> + ioport-shift = <1>;
>
> Bleh... that shift again. And this is surely not a good name for a
> property (where's I/O ports in your case?) -- why not call it "reg-
> shift"
> (well, I'd call it "reg-size" or "reg-stride" myself :-)?
I'm coming into this late, but if ioport-shift applies to reg (which I
think it does) it should really be called "reg-shift". The ePAPR is
using that property name:
Specifies in bytes how far the discrete device registers are separated
from each other. The
individual register location is calculated by using following formula:
“registers address” <<
reg-shift. If unspecified the default value is 0.
- k
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
