On Tue, Oct 06, 2015 at 11:18:42AM +0100, Steve Capper wrote:
> On 6 October 2015 at 10:09, Russell King - ARM Linux
> <li...@arm.linux.org.uk> wrote:
> > On Mon, Oct 05, 2015 at 06:02:10PM +0100, Suzuki K. Poulose wrote:
> >> +static int __init cpuinfo_regs_init(void)
> >> +{
> >> + int cpu, ret;
> >> +
> >> + for_each_present_cpu(cpu) {
> >> + struct device *dev = get_cpu_device(cpu);
> >> +
> >> + if (!dev)
> >> + return -1;
> >
> > NAK. Go figure out why, I'm too lazy to tell you.
>
> I will correct the return code to be -ENODEV.
> Was that the reasoning behind the NAK?
I suspect the half-initialised sysfs groups also have something to do
with it...
Mark.
>
> >
> >> +
> >> + ret = sysfs_create_group(&dev->kobj, &cpuregs_attr_group);
> >> + if (ret)
> >> + return ret;
> >> + }
> >> +
> >> + return 0;
> >> +}
> >> +
> >> +device_initcall(cpuinfo_regs_init);
> >> --
> >> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
