On Wed, Jun 03, 2026 at 03:05:07PM +0200, Sebastian Andrzej Siewior wrote: >imx_mu_specific_rx() masks channel 0 and unmasks it again at the end of >the function. Given that at startup the channel index got unmasked it >should do the right job. > >This here either unmasks the actual channel or another one but should >have no impact given that it reverses its doing at the end. > >Use the channel index instead of zero. > >Signed-off-by: Sebastian Andrzej Siewior <[email protected]> >--- > drivers/mailbox/imx-mailbox.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c >index 1dda1437b87f6..d1de07cc0ed62 100644 >--- a/drivers/mailbox/imx-mailbox.c >+++ b/drivers/mailbox/imx-mailbox.c >@@ -380,7 +380,7 @@ static int imx_mu_specific_rx(struct imx_mu_priv *priv, >struct imx_mu_con_priv * > > data = (u32 *)priv->msg; > >- imx_mu_xcr_rmw(priv, IMX_MU_RCR, 0, IMX_MU_xCR_RIEn(priv->dcfg->type, >0)); >+ imx_mu_xcr_rmw(priv, IMX_MU_RCR, 0, IMX_MU_xCR_RIEn(priv->dcfg->type, >cp->idx)); > *data++ = imx_mu_read(priv, priv->dcfg->xRR); > > if (priv->dcfg->type & IMX_MU_V2_S4) { >@@ -407,7 +407,7 @@ static int imx_mu_specific_rx(struct imx_mu_priv *priv, >struct imx_mu_con_priv * > *data++ = imx_mu_read(priv, priv->dcfg->xRR + (i % num_rr) * 4); > } > >- imx_mu_xcr_set_act(priv, cp, IMX_MU_RCR, >IMX_MU_xCR_RIEn(priv->dcfg->type, 0)); >+ imx_mu_xcr_set_act(priv, cp, IMX_MU_RCR, >IMX_MU_xCR_RIEn(priv->dcfg->type, cp->idx)); > mbox_chan_received_data(cp->chan, (void *)priv->msg);
For specific rx channel, whether it is i.MX8 SCU or i.MX ELE, actually there is only 1 channel as of now, but it seems better to use cp->idx in case more channels in future. Reviewed-by: Peng Fan <[email protected]> > > return 0; > >-- >2.53.0 >
