Hi, Arnd, On Thu, Mar 10, 2011 at 8:38 PM, Arnd Bergmann <a...@arndb.de> wrote: > On Monday 07 March 2011, Arnd Bergmann wrote: >> On Monday 07 March 2011, Shawn Guo wrote: >> > > diff --git a/arch/arm/mach-mx5/Makefile b/arch/arm/mach-mx5/Makefile >> > > index 0d43be9..540697e 100644 >> > > --- a/arch/arm/mach-mx5/Makefile >> > > +++ b/arch/arm/mach-mx5/Makefile >> > > @@ -18,3 +18,4 @@ obj-$(CONFIG_MACH_EUKREA_CPUIMX51SD) += >> > > board-cpuimx51sd.o >> > > obj-$(CONFIG_MACH_EUKREA_MBIMXSD51_BASEBOARD) += >> > > eukrea_mbimxsd-baseboard.o >> > > obj-$(CONFIG_MACH_MX51_EFIKAMX) += board-mx51_efikamx.o >> > > obj-$(CONFIG_MACH_MX50_RDP) += board-mx50_rdp.o >> > > +obj-$(CONFIG_MACH_MX51_DT) += board-dt.o >> > >> > If board-dt.c is mx51 specific, would it be sane to name it something >> > like board-mx51-dt.c? We have mx53 stuff in this folder as well. >> > >> >> Alternatively, it could be done the other way round: rename the identifiers >> in the file from mx51_ to mx5_, and make sure that they don't contain >> any mx51 specific settings but always refer to properties in the >> device tree for the differences. > > Hi Jason, > > I saw that your V4 still implements neither Shawn's suggestion nor mine.
As you said, I don't want to make thing complex too. I don't want to have mx51_dt or mx53_dt as Shawn Suggests and I still don't want to make it change to mx5 now as you suggest Since this patch only support mx51 currently. I think it's easy to make change later once mx53 in-deed added in DT support, what do you think? > > Arnd > _______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
