Hi, Shawn,
On Mon, Mar 7, 2011 at 10:51 PM, Shawn Guo <shawn....@freescale.com> wrote:
> Aha, Jason. Grant and I put many comments on v1 of this patch, but it
> seems that v2 is identical to v1, except adding Rob Herring sign-off.
Please compare with v1 and say it once again, It should include the
grant and your comments except the mxctty1
due to I think that it's not one issue, So, I did not take your comments.
But I observed that some comments as Grant suggest to use decimal not
hex value for #address-cells and #size-cells,
not applied to this file globally, I will fix it in the V3 patch if need.
>
> On Mon, Mar 07, 2011 at 09:05:59PM +0800, Jason Liu wrote:
>> Signed-off-by: Jason Liu <r64...@freescale.com>
>> Singed-off-by: Rob Herring <robherri...@gmail.com>
>> ---
>> arch/arm/boot/dts/babbage.dts | 110
>> +++++++++++++++++++++++++++++++++++++++++
>> 1 files changed, 110 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/babbage.dts b/arch/arm/boot/dts/babbage.dts
>> new file mode 100644
>> index 0000000..46a3071
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/babbage.dts
>> @@ -0,0 +1,110 @@
>> +/dts-v1/;
>> +
>> +/ {
>> + model = "Freescale i.MX51 Babbage";
>> + compatible = "fsl,mx51-babbage";
>> + #address-cells = <0x1>;
>> + #size-cells = <0x1>;
>> + #interrupt-cells = <0x1>;
>> + interrupt-parent = <&tzic>;
>> +
>> + memory {
>> + reg = <0x90000000 0x20000000>;
>> + };
>> +
>> + chosen {
>> + bootargs = "console=ttymxc1,115200n8 debug earlyprintk";
>> + };
>> +
>> + soc {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + compatible = "simple-bus";
>> + ranges;
>> +
>> + tzic: tzic@0 {
>> + #address-cells = <0>;
>> + #interrupt-cells = <1>;
>> + interrupt-controller;
>> + reg = <0xe0000000 0x1000>;
>> + compatible = "fsl,imx51-tzic";
>> + };
>> + };
>> +
>> + clocks {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + uart0_clk: uart@0 {
>> + compatible = "clock";
>> + clock-outputs = "imx-uart.0";
>> + };
>> +
>> + uart1_clk: uart@1 {
>> + compatible = "clock";
>> + clock-outputs = "imx-uart.1";
>> + };
>> +
>> + uart2_clk: uart@2 {
>> + compatible = "clock";
>> + clock-outputs = "imx-uart.2";
>> + };
>> +
>> + fec_clk: fec@0 {
>> + compatible = "clock";
>> + clock-outputs = "fec.0";
>> + };
>> + };
>> +
>> + spba@70000000 {
>> + #address-cells = <0x1>;
>> + #size-cells = <0x1>;
>> + compatible = "simple-bus";
>> + ranges = <0x0 0x70000000 0x100000>;
>> +
>> + imx-uart@c000 {
>> + compatible = "imx-uart";
>> + reg = <0xc000 0x1000>;
>> + interrupts = <0x21>;
>> + rts-cts;
>> + uart-clock = <&uart2_clk>, "uart";
>> + };
>> + };
>> +
>> + aips@73f00000 {
>> + #address-cells = <0x1>;
>> + #size-cells = <0x1>;
>> + compatible = "simple-bus";
>> + ranges = <0x0 0x73f00000 0x100000>;
>> +
>> + imx-uart@bc000 {
>> + compatible = "imx-uart";
>> + reg = <0xbc000 0x1000>;
>> + interrupts = <0x1f>;
>> + rts-cts;
>> + uart-clock = <&uart0_clk>, "uart";
>> + };
>> +
>> + imx-uart@c0000 {
>> + compatible = "imx-uart";
>> + reg = <0xc0000 0x1000>;
>> + interrupts = <0x20>;
>> + rts-cts;
>> + uart-clock = <&uart1_clk>, "uart";
>> + };
>> + };
>> +
>> + aips@83f00000 {
>> + #address-cells = <0x1>;
>> + #size-cells = <0x1>;
>> + compatible = "simple-bus";
>> + ranges = <0x0 0x83f00000 0x100000>;
>> +
>> + fec@ec000 {
>> + compatible = "fec";
>> + reg = <0xec000 0x1000>;
>> + interrupts = <0x57>;
>> + fec_clk-clock = <&fec_clk>, "fec";
>> + };
>> + };
>> +};
>> --
>> 1.7.0.4
>>
>>
>> _______________________________________________
>> linaro-dev mailing list
>> linaro-dev@lists.linaro.org
>> http://lists.linaro.org/mailman/listinfo/linaro-dev
>>
>
> --
> Regards,
> Shawn
>
>
_______________________________________________
linaro-dev mailing list
linaro-dev@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/linaro-dev
