Hi Mike,
I've only given this a quick look so far, but it's looking great. :)
Here are a few thoughts:
The patch doesn't apply without rebasing `paper-defaults-init.ly'.
Does `annotation-whiteout' do anything special? If not, the existing
property `whiteout' should suffice.
`reset-footnotes-on-new-page' appears to be broken:
\paper {
reset-footnotes-on-new-page = ##f
}
\relative c' {
\autoFootnoteGrob #'NoteHead #'(0 . -1) "first head"
c1
}
\pageBreak
\relative c' {
\autoFootnoteGrob #'NoteHead #'(0 . -1) "second head"
c1
}
-> "1", "1first head"
-> "1", "2second head"
`footnote-auto-numbering.ly' also counts the toplevel markup on the
second page as "5", continuing the marker sequence on the grobs with
"2", "3" etc.
The random hash you're creating is quite complicated; would a simple
(gensym "footnote") suffice?
If a footnote reaches double digits on a toplevel markup, it messes up
the superscript alignment for all toplevel markup footnotes.
Cheers,
Neil
http://codereview.appspot.com/4244064/
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
