Thanks for your comments. On Die, 2006-03-14 at 13:05 -0500, Bryan Kadzban wrote: > On Tue, Mar 14, 2006 at 02:10:27PM +0100, J?rg Billeter wrote: > > a="$(echo -ne '\001')" > > b="$(echo -ne '\002')" > > These can probably be simplified to: > > a=$'\001' > b=$'\002'
Didn't know that, changed. > > > pushd $KERNEL_PATH/include > > I don't think you need to pushd at the start and then popd at the end of > the script. The script's environment (including its current working > directory) will already be thrown away when it exits; doing a "cd" will > be just as good. Yes, sure, that was a relict from a previous script. > > > # delete the headers marked for removal > > rm -rvf $REMOVE_HEADERS > > This might run out of argv space; it might be better to: > > for file in $REMOVE_HEADERS ; do rm -rvf $file ; done > > or something similar with find/xargs. argv space is pretty big but will probably replace it with a xargs line. > Moving on to the test script: > [...] > Would this be a little more clear if the sense of the "[" was reversed? > > [ "$header" == "$noheader" ] && continue 2 > > would be how I'd do it. I doubt it matters much, though. Probably more clear, yes, changed that. > > Alternately, it might be possible to exclude $NO_TEST_HEADERS from the > find; something like: > [...] > might work, although I haven't actually tested it. It might also not be > specific enough; if linux/x.h and asm/x.h both exist, and linux/x.h > needs to be excluded but asm/x.h doesn't, this will exclude both. So That would really be problematic. Jürg -- http://linuxfromscratch.org/mailman/listinfo/lfs-dev FAQ: http://www.linuxfromscratch.org/faq/ Unsubscribe: See the above information page
