> On May 31, 2012, 4:29 p.m., Lamarque Souza wrote: > > /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningpreferences.cpp, > > line 27 > > <http://svn.reviewboard.kde.org/r/6960/diff/2/?file=48041#file48041line27> > > > > Send the change to klistwidget in a different review please. They will > > be applied in different commits so it will be easier if they were in > > different reviews. > > Cyberbeat wrote: > If you don't mind, I would leave it here, but I would make the two > different commits to svn (for my luck the changesets are distinct). Is there > a possibility to track different changes in svn without having two different > checkouts?
I do not think it is possible to do that with svn. > On May 31, 2012, 4:29 p.m., Lamarque Souza wrote: > > /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.cpp, line 94 > > <http://svn.reviewboard.kde.org/r/6960/diff/2/?file=48039#file48039line94> > > > > Hmmm we have a problem. The nowplaying plugin assume the ::update() > > method is synchronous, so we cannot use QDBusPendingReply here or it will > > cause undesired side effects. I think we will have to use the old version > > of this patch until someone fix that in the nowplaying plugin. > > Cyberbeat wrote: > mhm, in this case it won't have bad side effects, because the track > information is stored in local variables, which are retrieved after calling > update. Only thing that happens is, that updates eventually reach the caller > 5 seconds later. and that is what can cause side effects. Look at the now playing plugin code, it calls player->update() and right after that it calls player->playing() or player->newTrack(). The value used by playing() and newTrack() can be outdated now since player->update() is asynchronous (the player->update() call will return before the player state is updated, which is not what player->playing() and player->newTrack() expect). One solution for that is making ::update() emit a signal indicating when the song info is really updated (when both QDBusWatchers in the player backend in this patch finish). But that requires updates in all player backends. - Lamarque ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6960/#review10809 ----------------------------------------------------------- On May 31, 2012, 4:22 p.m., Cyberbeat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6960/ > ----------------------------------------------------------- > > (Updated May 31, 2012, 4:22 p.m.) > > > Review request for Kopete. > > > Description > ------- > > Add support for mpris2 in nowlistening-plugin > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/CMakeLists.txt 1297322 > /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.h PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.cpp PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningplugin.cpp > 1297322 > > /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningpreferences.cpp > 1297322 > /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningprefs.ui > 1297322 > > Diff: http://svn.reviewboard.kde.org/r/6960/diff/ > > > Testing > ------- > > works for me (banshee) > > > Thanks, > > Cyberbeat > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
