----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6960/#review10809 -----------------------------------------------------------
/trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.cpp <http://svn.reviewboard.kde.org/r/6960/#comment13404> Hmmm we have a problem. The nowplaying plugin assume the ::update() method is synchronous, so we cannot use QDBusPendingReply here or it will cause undesired side effects. I think we will have to use the old version of this patch until someone fix that in the nowplaying plugin. /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningpreferences.cpp <http://svn.reviewboard.kde.org/r/6960/#comment13405> Send the change to klistwidget in a different review please. They will be applied in different commits so it will be easier if they were in different reviews. - Lamarque Souza On May 31, 2012, 4:22 p.m., Cyberbeat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6960/ > ----------------------------------------------------------- > > (Updated May 31, 2012, 4:22 p.m.) > > > Review request for Kopete. > > > Description > ------- > > Add support for mpris2 in nowlistening-plugin > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/CMakeLists.txt 1297322 > /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.h PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.cpp PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningplugin.cpp > 1297322 > > /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningpreferences.cpp > 1297322 > /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningprefs.ui > 1297322 > > Diff: http://svn.reviewboard.kde.org/r/6960/diff/ > > > Testing > ------- > > works for me (banshee) > > > Thanks, > > Cyberbeat > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
