----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6960/#review10807 -----------------------------------------------------------
/trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.cpp <http://svn.reviewboard.kde.org/r/6960/#comment13400> This implementation is basically a copy of the mpris plugin replacing the dbus service and interface names. In the original mpris implementation this line search for the string "org.mpris." and not "org.mpris.MediaPlayer". Now I am in doubt if this line should also be "org.mpris." or the other line should be "org.mpris.MediaPlayer". I am not an expert in mpris so I do not know each one should be used here. /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.cpp <http://svn.reviewboard.kde.org/r/6960/#comment13402> just a petty peeve: you should be consistent in the code styling. Here there are one space missing after '(' and one before ')'. Actually there are several inconsistences in the code style for the 'if (...)' clause in this patch. /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.cpp <http://svn.reviewboard.kde.org/r/6960/#comment13401> please remove extra line. /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.cpp <http://svn.reviewboard.kde.org/r/6960/#comment13398> remove extra space. /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.cpp <http://svn.reviewboard.kde.org/r/6960/#comment13399> remove extra spaces. - Lamarque Souza On May 30, 2012, 11:23 p.m., Cyberbeat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6960/ > ----------------------------------------------------------- > > (Updated May 30, 2012, 11:23 p.m.) > > > Review request for Kopete. > > > Description > ------- > > Add support for mpris2 in nowlistening-plugin > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/CMakeLists.txt 1297322 > /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.h PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.cpp PRE-CREATION > /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningplugin.cpp > 1297322 > > /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningpreferences.cpp > 1297322 > > Diff: http://svn.reviewboard.kde.org/r/6960/diff/ > > > Testing > ------- > > works for me (banshee) > > > Thanks, > > Cyberbeat > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
