Hi Em 13/07/2009, às 09:50, Lamarque Vieira Souza escreveu:
> Em Monday 13 July 2009, Tiago Salem Herrmann escreveu: >> Lamarque Souza wrote: >>> Changes >>> ------- >>> >>> Assign NULL to tmpMailfile after delete, I have always assumed that >>> delete did that itself, but it seem I was wrong. The bad news is >>> that >>> there are other places in WLM plugin that do not assign NULL after a >>> delete (some places do it), maybe this is the cause of several >>> unexpected >>> crashes in Kopete. >> >> Could you please point them out? >> To be honest, it has been a long time my kopete do not crash. > > I created this review request http://reviewboard.kde.org/r/1004 to > show the > for the WLM protocol. There are 1105 places to analise the delete, > several of > them with problems, but it is too much work to do so I did it only > for the WLM > protocol for now. Well, Kopete, Kmail, Konqueror, Kppp and plasma > sometimes > crashes here with no appearent reason. In the plasma case it is the > notification applet that crashes and bring plasma down too. Maybe it > is > something related to delete not nullifing the pointer. It is usually a better approach to analyze the backtrace of the crash than to start blindly setting pointers to zero after deletion. I'm not saying pointers shouldn't be resetted after deleting, but usually fixing a crash involves more than just doing that. Cheers Boiko _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
