----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/971/#review1635 -----------------------------------------------------------
/trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmaccount.cpp <http://reviewboard.kde.org/r/971/#comment1071> According krun.h autodelete is enabled by default, so I assumed it would delete itself after finishing its job. /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmaccount.cpp <http://reviewboard.kde.org/r/971/#comment1072> This is why I call slotRemoveTmpMailFile some lines above and in WlmAccount destructor. Even if the user opens inbox twice the second run will delete the first temporary file before allocating the new one. If user opens inbox and close Kopete WlmAccount's destructor will remove the temporary file. What I implemented is similar to what you described except there is only file in QStringList. I thought about using QSTringList too, but then I thought I could do it with only one temporary file. One problem that occured be now is if user opens inbox twice, QTimer:singleShot is not stopped, then the second run may not have enough time to open the second temporary file before the first QTimer::singleShot calls slotRemoveTmpMailFile to delete it. Using your approach can void that or I can use a QTimer instance instead of QTimer::singleShot, stop the timer after deleting the temporary file and restart it after launching the browser. - Lamarque On 2009-07-16 20:30:50, Lamarque Souza wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/971/ > ----------------------------------------------------------- > > (Updated 2009-07-16 20:30:50) > > > Review request for Kopete. > > > Summary > ------- > > The patch implements mail notification and open inbox feature for wlm plugin. > It also adds four new strings for translation. I am using it with Kopete > 4.2.4 with no problems so far. The open inbox feature depends on this patch > applied against libmsn: > http://bach.metasys.com.br/~lamarque/kopete/libmsn-4.0_beta5-open_inbox.diff > > This is a quick and dirty way to test this patch: > > wget > http://bach.metasys.com.br/~lamarque/kopete/libmsn-4.0_beta5-open_inbox.diff > wget http://gentoo.oregonstate.edu/distfiles/libmsn-4.0-beta5.tar.bz2 > tar jxf libmsn-4.0-beta5.tar.bz2 > cd libmsn-4.0-beta5 > patch -p0 < ../libmsn-4.0_beta5-open_inbox.diff > mkdir ../libmsn-4.0-beta5_build > cd ../libmsn-4.0-beta5_build > cmake ../libmsn-4.0-beta5 > make; make install > > # Do backup of your kopete_wlm.so file first, usually it is located at > $KDEDIR/lib/kde4/ > # Download kopete-wlm_mail_notification_and_open_inbox.diff using the > "Download Diff" button at http://reviewboard.kde.org/r/971/ > wget ftp://ftp.kde.org/pub/kde/stable/4.2.4/src/kdenetwork-4.2.4.tar.bz2 > tar jxf kdenetwork-4.2.4.tar.bz2 > cd kdenetwork-4.2.4/kopete/ > patch -p0 < kopete-wlm_mail_notification_and_open_inbox.diff > mkdir ../../kdenetwork-4.2.4_build > cd ../../kdenetwork-4.2.4_build > cmake ../kdenetwork-4.2.4 > cd ../kdenetwork-4.2.4/kopete > make > cp ../lib/kopete_wlm.so /usr/kde/4.2/lib64/kde4/kopete_wlm.so # or the > location of your kopete_wlm.so plugin. > > Run Kopete :-) OBS: this installation method is not well tested and may not > work for everybody. > > > This addresses bug 163225. > https://bugs.kde.org/show_bug.cgi?id=163225 > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmaccount.cpp 997577 > /trunk/KDE/kdenetwork/kopete/protocols/wlm/CMakeLists.txt 993925 > /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmaccount.h 995564 > /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmlibmsn.h 993925 > /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmlibmsn.cpp 995415 > > Diff: http://reviewboard.kde.org/r/971/diff > > > Testing > ------- > > > Screenshots > ----------- > > Notification with ignore button > http://reviewboard.kde.org/r/971/s/138/ > > > Thanks, > > Lamarque > > _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
