----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/971/ -----------------------------------------------------------
(Updated 2009-07-16 20:30:50.820700) Review request for Kopete. Changes ------- I have changed three out of four of the new strings I added to make it easier to translate them. Now they are very similar to the strings used in Yahoo protocol source code, two of then just need to change the word Yahoo to Hotmail. The third also need to change Yahoo to Hotmail and adds '<p>Subject: %1' to the string. The fourth string is 'Open Inbox', similar to 'Open Inbo&x...' that exists in Wlm protocol source code, but using the latter did not work (it was not translated) so I kept 'Open Inbox' instead. This change also makes Wlm protocol interface more consistent with Yahoo protocol interface. I would like to know if there is anything else to change in the code. I am not using BrowerRun because KRun suggested by Tiago does the some thing (BrowserRun inherit from KRun). Using a temporary file is necessary when user wants to open the inbox using a browser differnt from Konqueror (or other kpart based browser). The temporary file is deleted after 30s so I think security risk is minimal (only if Kopete crashes during this time the file will not be deleted). Summary ------- The patch implements mail notification and open inbox feature for wlm plugin. It also adds four new strings for translation. I am using it with Kopete 4.2.4 with no problems so far. The open inbox feature depends on this patch applied against libmsn: http://bach.metasys.com.br/~lamarque/kopete/libmsn-4.0_beta5-open_inbox.diff This is a quick and dirty way to test this patch: wget http://bach.metasys.com.br/~lamarque/kopete/libmsn-4.0_beta5-open_inbox.diff wget http://gentoo.oregonstate.edu/distfiles/libmsn-4.0-beta5.tar.bz2 tar jxf libmsn-4.0-beta5.tar.bz2 cd libmsn-4.0-beta5 patch -p0 < ../libmsn-4.0_beta5-open_inbox.diff mkdir ../libmsn-4.0-beta5_build cd ../libmsn-4.0-beta5_build cmake ../libmsn-4.0-beta5 make; make install # Do backup of your kopete_wlm.so file first, usually it is located at $KDEDIR/lib/kde4/ # Download kopete-wlm_mail_notification_and_open_inbox.diff using the "Download Diff" button at http://reviewboard.kde.org/r/971/ wget ftp://ftp.kde.org/pub/kde/stable/4.2.4/src/kdenetwork-4.2.4.tar.bz2 tar jxf kdenetwork-4.2.4.tar.bz2 cd kdenetwork-4.2.4/kopete/ patch -p0 < kopete-wlm_mail_notification_and_open_inbox.diff mkdir ../../kdenetwork-4.2.4_build cd ../../kdenetwork-4.2.4_build cmake ../kdenetwork-4.2.4 cd ../kdenetwork-4.2.4/kopete make cp ../lib/kopete_wlm.so /usr/kde/4.2/lib64/kde4/kopete_wlm.so # or the location of your kopete_wlm.so plugin. Run Kopete :-) OBS: this installation method is not well tested and may not work for everybody. This addresses bug 163225. https://bugs.kde.org/show_bug.cgi?id=163225 Diffs (updated) ----- /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmaccount.cpp 997577 /trunk/KDE/kdenetwork/kopete/protocols/wlm/CMakeLists.txt 993925 /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmaccount.h 995564 /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmlibmsn.h 993925 /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmlibmsn.cpp 995415 Diff: http://reviewboard.kde.org/r/971/diff Testing ------- Screenshots ----------- Notification with ignore button http://reviewboard.kde.org/r/971/s/138/ Thanks, Lamarque _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
