Hi John, Thank you for the patches. I have tested them on Linux and Windows, and everything works as expected. I think the layer widget looks even better now, good job!
Cheers, Orson On 03/01/2017 01:11 AM, John Beard wrote: > Hi Wayne, > > On Wed, Mar 1, 2017 at 2:06 AM, Wayne Stambaugh <stambau...@gmail.com> wrote: >> Sorry John. I was going to recommend we apply your patch as is >> (assuming you didn't change the click behavior) to fix the gtk issue. >> We can discuss other changes to the behavior later. > > I haven't changed any behaviour or positioning. These are orthogonal > to this patch, and clearly have unresolved issues around them! > > I did try (separately) to put the colour wells on the right, and had > some success, but getting a wxFlexGridSizer to do the right thing even > for long strings that go off the end (think gerbview) is non-trivial, > so I put it aside for now. Perhaps a wxGrid would work better. > > Another thing we probably should fix is to put this widget in > common/widgets or something, because it's currently sneakily included > in gerbview's CMake, but it lives in pcbnews's directory. > > Cheers, > > John > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp >
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
