Wayne, I would like to merge the COLOR4D patches today, once I confirm with Jon they are complete.
Regards, Orson On 02/21/2017 03:41 PM, Wayne Stambaugh wrote: > I forgot to mention that this will likely clash with the COLOR4D work > that is already in progress so we will have to coordinate the changes. > @Orson, how soon will you be able to merge the COLOR4D code into master? > If it's going to be a while, we can merge this patch set and rebase the > COLOR4D code. Otherwise, lets get the COLOR4D code merged so John can > rebase his color swatch code. > > On 2/21/2017 9:35 AM, Wayne Stambaugh wrote: >> My only issue with this change is that the tooltip letting the user know >> that a left button double click or a middle button click would allow >> them to change the color is gone. Other than that, it looks great. I >> like the use of Bind instead of Connect. Bind has a much cleaner >> interface than Connect and according to the wx folks is the proper way >> to handle events. >> >> On 2/21/2017 8:04 AM, John Beard wrote: >>> Hi, >>> >>> These patches fix the layer/render widget swatches in Linux under new >>> GTK+ toolkits. Fix for: https://bugs.launchpad.net/kicad/+bug/1605411 >>> >>> The patches remove the "button" nature of the swatches, since they >>> weren't actually actuated by a single click, so the button affordance >>> was misleading anyway. Also on OSX, the button was invisible, so it >>> just looked like a flat swatch anyway. >>> >>> * Linux as it was: >>> https://drive.google.com/file/d/0BxVhl5qZbpYoZlZPeXV1Q0ttT2s/view >>> * OSX as it was: >>> https://launchpadlibrarian.net/274428737/Screen%20Shot%202016-07-22%20at%2019.40.14.png >>> * Linux after this patch: see attachment >>> >>> This is followed by a refactor to pull the swatch logic out of the >>> layer widget into common, where it can be used by other clients, for >>> example the eeschema display color dialog, if wanted. >>> >>> Patch #3 is a simple replacement of old WX Connect with Bind for >>> consistency in that file. >>> >>> Cheers, >>> >>> John >>> >>> >>> >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : kicad-developers@lists.launchpad.net >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >>> > > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp >
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
