https://bugs.kde.org/show_bug.cgi?id=374191
--- Comment #16 from Mario Frank <mario.fr...@uni-potsdam.de> --- (In reply to Simon from comment #15) > Hi Mario, > > I justed tested it and it worked as expected. > I have a question/proposition: The existing slotNewDuplicatesSearch > funciton accepts a generic album pointer and then determines what type > (physical/tag) it is. You made two distinct functions for lists as > arguments that still accept generic album pointers but named them to > make it clear that either physical or tag albums are expected. Wouldn't > it be cleaner and less error prone to use one function name > (slotNewDuplicatesSearch) and overload it with different parameters > (PAlbum*, TAlbum*, QList<PAlbum*> and QList<TAlbum*>)? Hi Simon, I am not completely happy with this solution. But the AlbumTreeView from which the TagFolderView is derived only provides me access to the list of selected tags as list of Album pointers. Using overloaded methods is also my preferred way. But to do this, I would either have to transform the list of Album pointers to a list of TAlbum pointers which is an unnecessary complexity. Or I will have to adopt the AlbumTreeView for this. The latter is the way to go, I think. -- You are receiving this mail because: You are watching all bug changes.
