abbccdda commented on a change in pull request #9103:
URL: https://github.com/apache/kafka/pull/9103#discussion_r504408633
##########
File path:
clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsResponse.java
##########
@@ -43,15 +43,43 @@
*/
public class ApiVersionsResponse extends AbstractResponse {
+ public static final int MIN_CONSTRAINT_IBP_VERSION = 31;
Review comment:
The tricky thing here is that if we handle the api version constraints
on the broker side, it means we need to either make changes directly to the
returned ApiVersionsResponse or spawn a new instance with applied constraints.
That means leaking of the internal architecture of ApiVersionsResponse to the
broker level and redundant conversions IMHO. The current approach makes sure
the broker level logic is clean with only the necessity of passing the IBP
number.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
