squah-confluent commented on code in PR #22488: URL: https://github.com/apache/kafka/pull/22488#discussion_r3452372310
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/util/OverlayMap.java: ########## @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.coordinator.group.util; + +import java.util.AbstractMap; +import java.util.AbstractSet; +import java.util.HashMap; +import java.util.HashSet; +import java.util.Iterator; +import java.util.Map; +import java.util.NoSuchElementException; +import java.util.Objects; +import java.util.Set; + +/** + * A map which wraps an underlying base map and accepts incremental updates + * that overlay on top of it. This class expects the underlying base map to + * be immutable. + * + * <p>Null values are not supported. + * + * @param <K> The key type. + * @param <V> The value type. + */ +public class OverlayMap<K, V> extends AbstractMap<K, V> { + /** Whether the map has been closed. */ + private boolean closed = false; + + private final Map<K, V> base; + + /** Entries whose keys are not in the base. */ + private final Map<K, V> additions = new HashMap<>(); + + /** Entries whose keys are in the base, with a value that supersedes the base value. */ + private final Map<K, V> replacements = new HashMap<>(); + + /** Keys that are in the base but have been removed. */ + private final Set<Object> removals = new HashSet<>(); + + private transient Set<Entry<K, V>> entrySet; Review Comment: It's used a lot in the JDK collections. When a class is `Serializable`, it excludes fields from serialization. Since we don't use that feature we can remove it. ########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ########## @@ -4149,19 +4173,98 @@ private UpdateTargetAssignmentResult<Assignment> maybeUpdateTargetAssignment( group.groupId(), groupEpoch, preferredServerAssignor, assignorTimeMs); } - records.addAll(assignmentResult.records()); + return assignmentResult; + }; + + if (offloadAssignor) { + assignmentResultBuilder.freezeInputs(); + Map<String, String> previousStaticMembers = Map.copyOf(updatedMembersAndTargetAssignment.staticMembers()); + // The view is backed by the group's timeline data structures, which may have been + // modified by the time the executor task runs. + updatedMembersAndTargetAssignment.close(); + + executor.schedule( + targetAssignmentUpdateKey, + buildTargetAssignment::get, + (result, exception) -> { Review Comment: Moved the handlers into their own methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
