squah-confluent commented on code in PR #22488:
URL: https://github.com/apache/kafka/pull/22488#discussion_r3452357274
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -4149,19 +4173,98 @@ private UpdateTargetAssignmentResult<Assignment>
maybeUpdateTargetAssignment(
group.groupId(), groupEpoch, preferredServerAssignor,
assignorTimeMs);
}
- records.addAll(assignmentResult.records());
+ return assignmentResult;
+ };
+
+ if (offloadAssignor) {
+ assignmentResultBuilder.freezeInputs();
Review Comment:
Replaced the design with three builders: `GroupSpecBuilder`,
`TargetAssignmentBuilder` and `TargetAssignmentRecordsBuilder`.
`GroupSpecBuilder` has a `withAssignorOffload(boolean)` that copies the data
going into the GroupSpec when set.
`TargetAssignmentBuilder` now takes a `GroupSpec` and is constructed and run
on the background thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
