squah-confluent commented on code in PR #22488:
URL: https://github.com/apache/kafka/pull/22488#discussion_r3452346408
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -2453,6 +2456,7 @@ private
CoordinatorResult<ConsumerGroupHeartbeatResponseData, CoordinatorRecord>
) throws ApiException {
final long currentTimeMs = time.milliseconds();
final List<CoordinatorRecord> records = new ArrayList<>();
+ final CompletableFuture<Void> appendFuture = new CompletableFuture<>();
Review Comment:
Thanks for reviewing. I replaced the `appendFuture` usage with a `(group id,
assignment epoch)` map to track in-flight assignors. When the group epoch is
bumped and <= an inflight assignor epoch, the inflight assignor must be using
stale data and cancelled. The downside is that we have to be careful to do the
check in every place we bump the group epoch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
