squah-confluent commented on code in PR #22488:
URL: https://github.com/apache/kafka/pull/22488#discussion_r3452363053
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -4149,19 +4173,98 @@ private UpdateTargetAssignmentResult<Assignment>
maybeUpdateTargetAssignment(
group.groupId(), groupEpoch, preferredServerAssignor,
assignorTimeMs);
}
- records.addAll(assignmentResult.records());
+ return assignmentResult;
+ };
+
+ if (offloadAssignor) {
+ assignmentResultBuilder.freezeInputs();
+ Map<String, String> previousStaticMembers =
Map.copyOf(updatedMembersAndTargetAssignment.staticMembers());
+ // The view is backed by the group's timeline data structures,
which may have been
+ // modified by the time the executor task runs.
+ updatedMembersAndTargetAssignment.close();
Review Comment:
Here it was supposed to disallow further usage of the view and maps. It's
been removed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
