junrao commented on code in PR #18726: URL: https://github.com/apache/kafka/pull/18726#discussion_r1972525165
########## clients/src/main/resources/common/message/FetchResponse.json: ########## @@ -106,7 +106,7 @@ ]}, { "name": "PreferredReadReplica", "type": "int32", "versions": "11+", "default": "-1", "ignorable": false, "entityType": "brokerId", "about": "The preferred read replica for the consumer to use on its next fetch request."}, - { "name": "Records", "type": "records", "versions": "0+", "nullableVersions": "0+", "about": "The record data."} Review Comment: Sorry for the late reply. It seems that before https://github.com/apache/kafka/commit/fe56fc98fa736c79c9dcbb1f64f810065161a1cc, we already have a bunch of calls like the following that will leave records as null in the fetchResponse. ` erroneous += topicIdPartition -> FetchResponse.partitionResponse(topicIdPartition, Errors.TOPIC_AUTHORIZATION_FAILED)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org