ijuma commented on code in PR #19016:
URL: https://github.com/apache/kafka/pull/19016#discussion_r1970909685
##########
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##########
@@ -173,12 +173,13 @@ public class TopicConfig {
public static final String MIN_IN_SYNC_REPLICAS_DOC = "When a producer
sets acks to \"all\" (or \"-1\"), " +
"this configuration specifies the minimum number of replicas that must
acknowledge " +
"a write for the write to be considered successful. If this minimum
cannot be met, " +
- "then the producer will raise an exception (either NotEnoughReplicas
or " +
- "NotEnoughReplicasAfterAppend).<br>When used together,
<code>min.insync.replicas</code> and <code>acks</code> " +
- "allow you to enforce greater durability guarantees. A typical
scenario would be to " +
- "create a topic with a replication factor of 3, set
<code>min.insync.replicas</code> to 2, and " +
- "produce with <code>acks</code> of \"all\". This will ensure that the
producer raises an exception " +
- "if a majority of replicas do not receive a write.";
+ "then the producer will raise an exception (either
<code>NotEnoughReplicas</code> or
<code>NotEnoughReplicasAfterAppend</code>).<br> " +
+ "Regardless of the <code>acks</code> setting, the messages will not be
visible to the consumers until " +
+ "they are replicated to all in-sync replicas and
<code>min.insync.replicas</code> condition is met.<br> " +
+ "When used together, <code>min.insync.replicas</code> and
<code>acks</code> allow you to enforce greater durability guarantees. " +
+ "A typical scenario would be to create a topic with a replication
factor of 3, " +
+ "set <code>min.insync.replicas</code> to 2, and produce with
<code>acks</code> of \"all\". " +
+ "This will ensure that the producer raises an exception if a majority
of replicas do not receive a write.<br> ";
Review Comment:
Perhaps:
"This will ensure that a majority of replicas must persist a write before
it's considered successful by the producer and it's seen by consumers."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
