clarkwtc commented on code in PR #19016:
URL: https://github.com/apache/kafka/pull/19016#discussion_r1967648190
##########
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##########
@@ -178,7 +178,13 @@ public class TopicConfig {
"allow you to enforce greater durability guarantees. A typical
scenario would be to " +
"create a topic with a replication factor of 3, set
<code>min.insync.replicas</code> to 2, and " +
"produce with <code>acks</code> of \"all\". This will ensure that the
producer raises an exception " +
- "if a majority of replicas do not receive a write.";
+ "if a majority of replicas do not receive a write.<br> " +
+ "Topics have a setting for <code>min.insync.replicas</code> that is
checked when the producer requests acknowledgment " +
+ "that a message has been written to all in-sync replicas. " +
+ "If <code>acks=0</code>, the message may be committed asynchronously;
if <code>acks=1</code>, " +
+ "it’s committed synchronously on the leader.<br> " +
+ "Regardless of the <code>acks</code> setting, the messages will not be
visible to the consumers until " +
+ "they are replicated to all in-sync replicas and the
<code>min.insync.replicas</code> condition is met.";
Review Comment:
Exactly, there are some repeated descriptions in the existing documentation,
which I have removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
