ijuma commented on code in PR #19016: URL: https://github.com/apache/kafka/pull/19016#discussion_r1970906033
########## clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java: ########## @@ -173,12 +173,13 @@ public class TopicConfig { public static final String MIN_IN_SYNC_REPLICAS_DOC = "When a producer sets acks to \"all\" (or \"-1\"), " + "this configuration specifies the minimum number of replicas that must acknowledge " + "a write for the write to be considered successful. If this minimum cannot be met, " + Review Comment: Actually, this is not quite correct since it applies independently of the acks setting. Marking this as resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org