clarkwtc commented on code in PR #19016: URL: https://github.com/apache/kafka/pull/19016#discussion_r1971049031
########## server-common/src/main/java/org/apache/kafka/server/config/ServerTopicConfigSynonyms.java: ########## @@ -78,6 +78,7 @@ public final class ServerTopicConfigSynonyms { sameNameWithLogPrefix(TopicConfig.CLEANUP_POLICY_CONFIG), sameName(TopicConfig.UNCLEAN_LEADER_ELECTION_ENABLE_CONFIG), sameName(TopicConfig.MIN_IN_SYNC_REPLICAS_CONFIG), + sameName(TopicConfig.MIN_IN_SYNC_REPLICAS_DOC), Review Comment: This change is made because we can reference `MIN_IN_SYNC_REPLICAS_DOC` from `TopicConfig` in `ServerLogConfigs`. If we don't do it, it will got `Caused by: java.util.NoSuchElementException: No server synonym found for MIN_IN_SYNC_REPLICAS_DOC`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org