apoorvmittal10 commented on code in PR #18725:
URL: https://github.com/apache/kafka/pull/18725#discussion_r1931894291
##########
core/src/test/java/kafka/server/share/DelayedShareFetchTest.java:
##########
@@ -492,7 +492,7 @@ public void testForceCompleteTriggersDelayedActionsQueue() {
DelayedOperationPurgatory<DelayedShareFetch>
delayedShareFetchPurgatory = new DelayedOperationPurgatory<>(
"TestShareFetch", mockTimer, replicaManager.localBrokerId(),
- DELAYED_SHARE_FETCH_PURGATORY_PURGE_INTERVAL, true, true);
+ DELAYED_SHARE_FETCH_PURGATORY_PURGE_INTERVAL, false, true);
Review Comment:
Hmm, so do we have tests either in ReplicaManager or elsewhere to test
expirationReaper times out share fetch requests successfully?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
