apoorvmittal10 commented on code in PR #18725:
URL: https://github.com/apache/kafka/pull/18725#discussion_r1931897412
##########
core/src/test/java/kafka/server/share/DelayedShareFetchTest.java:
##########
@@ -704,6 +704,7 @@ public void testLocksReleasedForCompletedFetch() {
.withShareFetchData(shareFetch)
.withSharePartitions(sharePartitions1)
.withReplicaManager(replicaManager)
+
.withPartitionMaxBytesStrategy(PartitionMaxBytesStrategy.type(PartitionMaxBytesStrategy.StrategyType.UNIFORM))
Review Comment:
Why the change only over here and not in other methods? Also should we mock
the response from `PartitionMaxBytesStrategy`?
##########
core/src/test/java/kafka/server/share/DelayedShareFetchTest.java:
##########
@@ -492,7 +492,7 @@ public void testForceCompleteTriggersDelayedActionsQueue() {
DelayedOperationPurgatory<DelayedShareFetch>
delayedShareFetchPurgatory = new DelayedOperationPurgatory<>(
"TestShareFetch", mockTimer, replicaManager.localBrokerId(),
- DELAYED_SHARE_FETCH_PURGATORY_PURGE_INTERVAL, true, true);
+ DELAYED_SHARE_FETCH_PURGATORY_PURGE_INTERVAL, false, true);
Review Comment:
Hmm, so do we have tests either in ReplicaManager or elsewhere to
expirationReaper timed out for DelayShareFetch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
