adixitconfluent commented on code in PR #18725:
URL: https://github.com/apache/kafka/pull/18725#discussion_r1931915386
##########
core/src/test/java/kafka/server/share/DelayedShareFetchTest.java:
##########
@@ -704,6 +704,7 @@ public void testLocksReleasedForCompletedFetch() {
.withShareFetchData(shareFetch)
.withSharePartitions(sharePartitions1)
.withReplicaManager(replicaManager)
+
.withPartitionMaxBytesStrategy(PartitionMaxBytesStrategy.type(PartitionMaxBytesStrategy.StrategyType.UNIFORM))
Review Comment:
We need this change whenever there is a call to `readFromLog` functionality
in `DelayedShareFetch`. It was already present in the tests where this
functionality was called indirectly/directly. Somehow, this one got missed
earlier.
We can do the mocking of response as well from
`partitionMaxBytesStrategy.maxBytes`. It makes sense to me as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
