kevin-wu24 commented on code in PR #18304: URL: https://github.com/apache/kafka/pull/18304#discussion_r1929096754
########## raft/src/main/java/org/apache/kafka/raft/QuorumState.java: ########## @@ -722,8 +727,11 @@ public <T> LeaderState<T> transitionToLeader(long epochStartOffset, BatchAccumul accumulator, localListeners, fetchTimeoutMs, - logContext + logContext, + kafkaRaftMetrics ); + kafkaRaftMetrics.addLeaderMetrics(); Review Comment: Ah yeah, good catch. I remember RAII being mentioned from some C++ I did in college. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org