jsancio commented on code in PR #18304:
URL: https://github.com/apache/kafka/pull/18304#discussion_r1934789886
##########
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java:
##########
@@ -2351,4 +2459,21 @@ private static ApiVersionsResponseData
apiVersionsResponse(Errors error, Support
.setErrorCode(error.code())
.setSupportedFeatures(supportedFeatures);
}
+
+ private static KafkaMetric getMetric(final Metrics metrics, final String
name) {
+ return metrics.metrics().get(metrics.metricName(name, "raft-metrics"));
+ }
+
+ private static void checkLeaderMetricValues(
+ final int expectedVoters,
+ final int expectedObservers,
+ final boolean expectedUncommittedVoterChange,
+ final boolean expectedIgnoredStaticVoters,
Review Comment:
Makes sense to me to not test this configuration here. In that case don't
make it a parameter and simply check for false in the method body.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
