kevin-wu24 commented on PR #18304: URL: https://github.com/apache/kafka/pull/18304#issuecomment-2610879969
Thanks for the review @jsancio. Pushed some commits: - Added `MockExternalKRaftMetrics` to prevent additional raft module dependencies. Added `DefaultExternalKRaftMetricsTest` since raft layer tests use the mock instead. - The `staticVoterSet` passed to `KRaftControlRecordStateMachine` can never be `null`. Instead the default value for `controller.quorum.voters` is the empty list in both implementation and testing. Fixed updating logic for the `ignored-static-voters` metric so that it always stays false when the mentioned config is not set. Only when that config is actually set can the metric's value ever go from false to true. - In the case of `truncateNewEntries` truncating the entire log, if `controller.quorum.voters` is set, `ignored-static-voters` metric can go from true back to false. Implementation now covers for this case. - `KRaftControlRecordStateMachineTest` checks both `ignored-static-voters` and `number-of-voters` metric values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
