jsancio commented on code in PR #18304:
URL: https://github.com/apache/kafka/pull/18304#discussion_r1926013405
##########
server/src/main/java/org/apache/kafka/server/metrics/BrokerServerMetrics.java:
##########
@@ -89,12 +95,18 @@ public BrokerServerMetrics(Metrics metrics) {
METRIC_GROUP_NAME,
"The number of errors encountered by the
BrokerMetadataPublisher while applying a new MetadataImage based on the latest
MetadataDelta."
);
+ ignoredStaticVotersName = metrics.metricName(
+ "ignored-static-voters",
+ METRIC_GROUP_NAME,
+ "This value is 1 when the current voter set for the metadata topic
partition is being read from the log and 0 when it is read from the static
configuration."
Review Comment:
This description doesn't seem accurate. Is this what I state in the KIP? How
about:
> 1 if controller.quorum.voters is set but was not used by the broker, 0
otherwise.
Please feel free to update the KIP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
