chia7712 commented on code in PR #18566: URL: https://github.com/apache/kafka/pull/18566#discussion_r1923680550
########## core/src/main/scala/kafka/server/KafkaConfig.scala: ########## @@ -221,8 +213,6 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) def quotaConfig: QuotaConfig = _quotaConfig /** ********* General Configuration ***********/ - val brokerIdGenerationEnable: Boolean = getBoolean(ServerConfigs.BROKER_ID_GENERATION_ENABLE_CONFIG) - val maxReservedBrokerId: Int = getInt(ServerConfigs.RESERVED_BROKER_MAX_ID_CONFIG) var brokerId: Int = getInt(ServerConfigs.BROKER_ID_CONFIG) Review Comment: > If the behavior in 3.x is that the broker fails to start in KRaft mode unless node.id is set There's a potential regression if we remove `broker.id` because users can currently set it instead of `node.id`. However, this conflicts with our documentation, which states that `node.id` is mandatory. To address this, we could deprecate `broker.id` in version 4.x and then remove it entirely in version 5.x. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
